Michael Kublin has posted comments on this change.
Change subject: core: Use allow snapshot attribute on disk update.
......................................................................
Patch Set 3: (5 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
Line 32: private final Disk _oldDisk;
why we need final here? How it is helps?
Line 152: return false;
u return false here, but u already updated _oldDisk with garbage before
Line 154: } else if (isDiskShareable && !isDiskUpdatedToShareable) {
why not use getVm()?
Line 157: // If disk is not floating, then update its vm snapshot
id to the active VM snapshot.
how it can be, if there a check isVmExist()?
Line 166: // Check if VM is not during snapshot.
same again, strange logic, u field an object with garbage and after that, u are
saying wow we will not update it
--
To view, visit http://gerrit.ovirt.org/4232
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4488ad0d983854483aee5520ae2a233c96bfdb4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
