Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: legacy: use postgres db user
......................................................................
Patch Set 4:
(1 comment)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/legacy/database.py
Line 61: config = configfile.ConfigFile([
Line 62: osetupcons.FileLocations.LEGACY_OVIRT_ENGINE_SYSCONFIG
Line 63: ])
Line 64: legacy_user = config.get('ENGINE_DB_USER')
Line 65: self.logger.debug('legacy ENGINE_DB_USER: %s' %
legacy_user)
If /etc/sysconfig/ovirt-engine is missing, this won't fail, and legacy_user
will be None. d[3] will be a string, and so '==' will always be False and we'll
not enter the 'if'.
Still that's somewhat ugly, relies on configfile not failing on a missing
argument. If you want I'll push a fix.
Line 66: with open(
Line 67: osetupcons.FileLocations.LEGACY_PSQL_PASS_FILE,
Line 68: 'r',
Line 69: ) as f:
--
To view, visit http://gerrit.ovirt.org/23055
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I391cc532fd1673db9f6adb29fc0cce052992fda4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
