Juan Hernandez has posted comments on this change.
Change subject: restapi: Use correct parameters for network removal
......................................................................
Patch Set 4:
(1 comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendNetworksResource.java
Line 32: protected abstract VdcQueryParametersBase getQueryParameters();
Line 33:
Line 34: protected VdcActionParametersBase getActionParameters(Network
network, org.ovirt.engine.core.common.businessentities.network.Network entity) {
Line 35: return getActionParameters(network, entity, false);
Line 36: }
I think it is better if we create a "getRemoveParameters" method instead of
overloading "getActionParameters". The use of the boolean parameter makes the
calls a bit more difficult to read.
Going in the same directory, I would also suggest to rename the
"getActionParameters" to "getAddParameters", as I don't see it used in any
place other than adding networks.
Line 37:
Line 38: protected abstract VdcActionParametersBase
getActionParameters(Network network,
org.ovirt.engine.core.common.businessentities.network.Network entity, boolean
remove);
Line 39:
Line 40: public Networks list() {
--
To view, visit http://gerrit.ovirt.org/23185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf77dbf2a9027d5310d74fc9bceaad6e7d768ef2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
