Maor Lipchuk has posted comments on this change.

Change subject: dbscripts: fix password field length
......................................................................


Patch Set 1:

(1 comment)

....................................................
Commit Message
Line 10: a different type with respect to the correspinding parameter of
Line 11: the Insertstorage_server_connection function.
Line 12: 
Line 13: This leads to error when adding password-protected ISCSI storage
Line 14: domains.
Please also add the use case how this happened.
The password from ISCSI storage is coming from getDeviceList in VDSM so we 
can't be sure that this password will be 50 characters long
Line 15: 
Line 16: This patch fixes this problem by enlarging the password field on
Line 17: the table, in order to let it hold the encrypted password.
Line 18: 


-- 
To view, visit http://gerrit.ovirt.org/23133
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe5dcb58dd445216b43bbce63b342b96d5e225e6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to