Daniel Erez has posted comments on this change. Change subject: webadmin: Update network label GUI field ......................................................................
Patch Set 5: Code-Review+2 (2 comments) http://gerrit.ovirt.org/#/c/22902/5/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java: Line 675: getQos().setIsChangable(!externalNetwork); Line 676: getAddQosCommand().setIsExecutionAllowed(!externalNetwork); Line 677: Line 678: String label = getNetworkLabel().getSelectedItem(); Line 679: if (externalNetwork) { consider 'ternary if' here Line 680: getNetworkLabel().setItems(new HashSet<String>()); Line 681: } else { Line 682: getNetworkLabel().setItems(dcLabels); Line 683: } Line 685: } Line 686: Line 687: private void updateDcLabels() { Line 688: startProgress(null); Line 689: AsyncDataProvider.getNetworkLabelsByDataCenterId(getSelectedDc().getId(), new AsyncQuery(new INewAsyncCallback() { check formatter Line 690: Line 691: @Override Line 692: public void onSuccess(Object model, Object returnValue) { Line 693: dcLabels = (Iterable<String>) returnValue; -- To view, visit http://gerrit.ovirt.org/22902 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0ed563897fd1d7eb4acc9ff322373132f01f8c3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
