Doron Fediuck has posted comments on this change. Change subject: core: Adding affinity groups command and queries ......................................................................
Patch Set 11: (5 comments) s/EXSITS/EXISTS/ http://gerrit.ovirt.org/#/c/22715/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AddAffinityGroupCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AddAffinityGroupCommand.java: Line 14: Line 15: @Override Line 16: protected boolean canDoAction() { Line 17: if (getAffinityGroupDao().getByName(getParameters().getAffinityGroup().getName()) != null) { Line 18: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_AFFINITY_GROUP_NAME_EXSITS); s/EXSITS/EXISTS/ Line 19: } Line 20: return validateParameters(); Line 21: } Line 22: http://gerrit.ovirt.org/#/c/22715/11/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java: Line 913: ACTION_TYPE_FAILED_VM_NOT_IN_AFFINITY_GROUP_CLUSTER(ErrorType.BAD_PARAMETERS), Line 914: ACTION_TYPE_FAILED_DUPLICTE_VM_IN_AFFINITY_GROUP(ErrorType.BAD_PARAMETERS), Line 915: ACTION_TYPE_FAILED_INVALID_AFFINITY_GROUP_ID(ErrorType.BAD_PARAMETERS), Line 916: ACTION_TYPE_FAILED_CANNOT_CHANGE_CLUSTER_ID(ErrorType.BAD_PARAMETERS), Line 917: ACTION_TYPE_FAILED_AFFINITY_GROUP_NAME_EXSITS(ErrorType.BAD_PARAMETERS); s/EXSITS/EXISTS/ Line 918: Line 919: private ErrorType messageType; Line 920: Line 921: VdcBllMessages() { http://gerrit.ovirt.org/#/c/22715/11/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 1118: ACTION_TYPE_FAILED_VM_NOT_IN_AFFINITY_GROUP_CLUSTER=Cannot ${action} ${type}. Provided VM resides in another Cluster. Line 1119: ACTION_TYPE_FAILED_DUPLICTE_VM_IN_AFFINITY_GROUP=Cannot ${action} ${type}. Duplicate VM. Line 1120: ACTION_TYPE_FAILED_INVALID_AFFINITY_GROUP_ID=Cannot ${action} ${type}. No matching Affinity Group. Line 1121: ACTION_TYPE_FAILED_CANNOT_CHANGE_CLUSTER_ID=Cannot ${action} ${type}. Cannot change Cluster for Affinity Group. Line 1122: ACTION_TYPE_FAILED_AFFINITY_GROUP_NAME_EXSITS=Cannot ${action} ${type}. Affinity Group name already exists. s/EXSITS/EXISTS/ http://gerrit.ovirt.org/#/c/22715/11/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java: Line 2984: @DefaultStringValue("Cannot ${action} ${type}. Cannot change Cluster for Affinity Group.") Line 2985: String ACTION_TYPE_FAILED_CANNOT_CHANGE_CLUSTER_ID(); Line 2986: Line 2987: @DefaultStringValue("Cannot ${action} ${type}. Affinity Group name already exists.") Line 2988: String ACTION_TYPE_FAILED_AFFINITY_GROUP_NAME_EXSITS(); s/EXSITS/EXISTS/ http://gerrit.ovirt.org/#/c/22715/11/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties File frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties: Line 1092: ACTION_TYPE_FAILED_VM_NOT_IN_AFFINITY_GROUP_CLUSTER=Cannot ${action} ${type}. Provided VM resides in another Cluster. Line 1093: ACTION_TYPE_FAILED_DUPLICTE_VM_IN_AFFINITY_GROUP=Cannot ${action} ${type}. Duplicate VM. Line 1094: ACTION_TYPE_FAILED_INVALID_AFFINITY_GROUP_ID=Cannot ${action} ${type}. No matching Affinity Group. Line 1095: ACTION_TYPE_FAILED_CANNOT_CHANGE_CLUSTER_ID=Cannot ${action} ${type}. Cannot change Cluster for Affinity Group. Line 1096: ACTION_TYPE_FAILED_AFFINITY_GROUP_NAME_EXSITS=Cannot ${action} ${type}. Affinity Group name already exists. s/EXSITS/EXISTS/ -- To view, visit http://gerrit.ovirt.org/22715 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5251d0ee6ff2a719394cdb5ebec7b63e0ae37e3b Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
