Martin Peřina has posted comments on this change. Change subject: tools: Notification properties changes. ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/23080/4/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java: Line 43: * will process and send the events of the last two days, older events will Line 44: * just be marked as processed and won't be sent. Line 45: */ Line 46: public static final String DAYS_TO_SEND_ON_STARTUP = "DAYS_TO_SEND_ON_STARTUP"; Line 47: Was this reformat necessary? Line 48: /** Line 49: * Email parameters Line 50: */ Line 51: public static final String MAIL_SERVER = "MAIL_SERVER"; Line 201: String emailUser = getProperty(NotificationProperties.MAIL_USER, true); Line 202: if (StringUtils.isEmpty(emailUser) Line 203: && (MAIL_SMTP_ENCRYPTION_SSL.equals(getProperty(MAIL_SMTP_ENCRYPTION, true)) Line 204: || MAIL_SMTP_ENCRYPTION_TLS.equals(getProperty(MAIL_SMTP_ENCRYPTION, true)) Line 205: || StringUtils.isNotEmpty(getProperty(NotificationProperties.MAIL_PASSWORD, true)))) { Please leave formatting as it was, it was much more readable Line 206: throw new IllegalArgumentException( Line 207: String.format( Line 208: "'%s' must be set when SSL or TLS is enabled or when password is set", Line 209: NotificationProperties.MAIL_USER)); -- To view, visit http://gerrit.ovirt.org/23080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5753ba2cad2de90a7f2d14bd4675edc1dd35045e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
