Gilad Chaplik has posted comments on this change. Change subject: core,engine,webadmin: Automatic power management of hosts ......................................................................
Patch Set 11: Code-Review+2 (1 comment) minor comment, can be addressed in a later patch. http://gerrit.ovirt.org/#/c/22376/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java: Line 115: boolean initSucceeded = true; Line 116: Line 117: /* Host is UP, re-set the policy controlled power management flag */ Line 118: getVds().setPowerManagementControlledByPolicy(true); Line 119: DbFacade.getInstance().getVdsDynamicDao().updateVdsDynamicPowerManagementPolicyFlag( later extract a method for getting VdsDynamicDao, like for other DAOs (used for testing reasons - there's no test so it's fine for now). Line 120: getVds().getId(), Line 121: getVds().isPowerManagementControlledByPolicy()); Line 122: Line 123: if (vdsGroup.supportsTrustedService()) { -- To view, visit http://gerrit.ovirt.org/22376 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icdea8bdef15556be1591ffb7554f79238f865ec8 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
