Eli Mesika has posted comments on this change. Change subject: tools: Refactor model and DB mapping of eventNotificationMethods. ......................................................................
Patch Set 20: I would say that introducing enum types should be done (if we decide) cross all over the DB , we have bunch of statuses , types and other stuff that can be enum , I am against hybrid solutions from the reason that you don't know what is the right thing to do if you see more than one method. So, I am for investigating that and see if we can use that for the whole DB schema instead of the String representation but I will prefer that the current implementation in this patch will be String until we get to that point. One other point is : does using enums make our lives harder if we will switch to hibernate ? -- To view, visit http://gerrit.ovirt.org/22135 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b71c4e78bbdca3d02d2ac4ef419b9d3d7d58761 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
