Maor Lipchuk has posted comments on this change. Change subject: engine: Commands to add, edit and remove iscsi bonds ......................................................................
Patch Set 7: (12 comments) You don't use the message you added in appErrors.java. You should also add it to AppErrors.java http://gerrit.ovirt.org/#/c/22952/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java: Line 837: //mom policies Line 838: USER_UPDATED_MOM_POLICIES(10200), Line 839: USER_FAILED_TO_UPDATE_MOM_POLICIES(10201), Line 840: Line 841: // Iscsi bond /s/Iscsi/iSCSI Line 842: ISCSI_BOND_ADD_SUCCESS(10300), Line 843: ISCSI_BOND_ADD_FAILED(10301), Line 844: ISCSI_BOND_EDIT_SUCCESS(10302), Line 845: ISCSI_BOND_EDIT_FAILED(10303), Line 838: USER_UPDATED_MOM_POLICIES(10200), Line 839: USER_FAILED_TO_UPDATE_MOM_POLICIES(10201), Line 840: Line 841: // Iscsi bond Line 842: ISCSI_BOND_ADD_SUCCESS(10300), Please remember to change this code when rebasing since HA Reservation already use it Line 843: ISCSI_BOND_ADD_FAILED(10301), Line 844: ISCSI_BOND_EDIT_SUCCESS(10302), Line 845: ISCSI_BOND_EDIT_FAILED(10303), Line 846: ISCSI_BOND_REMOVE_SUCCESS(10304), http://gerrit.ovirt.org/#/c/22952/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java: Line 32: VAR__TYPE__HOST_CAPABILITIES, Line 33: VAR__TYPE__NETWORK_QOS, Line 34: VAR__TYPE__SPM, Line 35: VAR__TYPE__CLUSTER_POLICY, Line 36: VAR__TYPE__POLICY_UNIT, Please add VAR_TYPE_ISCSI_MULTIPATH Line 37: VAR__TYPE__SUBNET, Line 38: Line 39: // Gluster types Line 40: VAR__TYPE__GLUSTER_VOLUME, http://gerrit.ovirt.org/#/c/22952/7/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 1111: VALIDATION.ISCSI_BOND.DESCRIPTION.MAX=Iscsi bond description must not exceed 4000 characters Line 1112: VALIDATION.ISCSI_BOND.NAME.INVALID.CHARACTER=Iscsi Bond name must be formed from alpha-numeric characters or "-_." Line 1113: VALIDATION.ISCSI_BOND.DESCRIPTION.INVALID=Iscsi Bond description must be formed only from alpha-numeric characters and special characters that conform to the standard ASCII character set. Line 1114: Line 1115: ISCSI_BOND_NOT_EXISTS=The specified iscsi bond doesn't exist. Please add here Cannot ${action} ${type}... http://gerrit.ovirt.org/#/c/22952/7/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 737: VM_CONSOLE_CONNECTED=User ${UserName} is connected to VM ${VmName}. Line 738: VM_CONSOLE_DISCONNECTED=User ${UserName} got disconnected from VM ${VmName}. Line 739: VDS_STATUS_CHANGE_FAILED_DUE_TO_STOP_SPM_FAILURE=Failed to change status of host '${VdsName}' due to a failure to stop the spm. Line 740: Line 741: ISCSI_BOND_ADD_SUCCESS=Iscsi bond '${IscsiBondName}' was successfully created in Data Center '${StoragePoolName}'. /s/Iscsi bond/iSCSI Bond Line 742: ISCSI_BOND_ADD_FAILED=Failed to create Iscsi bond '${IscsiBondName}' in Data Center '${StoragePoolName}'. Line 743: ISCSI_BOND_EDIT_SUCCESS=Iscsi bond '${IscsiBondName}' was successfully updated. Line 744: ISCSI_BOND_EDIT_FAILED=Failed to update Iscsi bond '${IscsiBondName}'. Line 745: ISCSI_BOND_REMOVE_SUCCESS=Iscsi bond '${IscsiBondName}' was removed from Data Center '${StoragePoolName}' Line 738: VM_CONSOLE_DISCONNECTED=User ${UserName} got disconnected from VM ${VmName}. Line 739: VDS_STATUS_CHANGE_FAILED_DUE_TO_STOP_SPM_FAILURE=Failed to change status of host '${VdsName}' due to a failure to stop the spm. Line 740: Line 741: ISCSI_BOND_ADD_SUCCESS=Iscsi bond '${IscsiBondName}' was successfully created in Data Center '${StoragePoolName}'. Line 742: ISCSI_BOND_ADD_FAILED=Failed to create Iscsi bond '${IscsiBondName}' in Data Center '${StoragePoolName}'. /s/Iscsi bond/iSCSI Bond Line 743: ISCSI_BOND_EDIT_SUCCESS=Iscsi bond '${IscsiBondName}' was successfully updated. Line 744: ISCSI_BOND_EDIT_FAILED=Failed to update Iscsi bond '${IscsiBondName}'. Line 745: ISCSI_BOND_REMOVE_SUCCESS=Iscsi bond '${IscsiBondName}' was removed from Data Center '${StoragePoolName}' Line 739: VDS_STATUS_CHANGE_FAILED_DUE_TO_STOP_SPM_FAILURE=Failed to change status of host '${VdsName}' due to a failure to stop the spm. Line 740: Line 741: ISCSI_BOND_ADD_SUCCESS=Iscsi bond '${IscsiBondName}' was successfully created in Data Center '${StoragePoolName}'. Line 742: ISCSI_BOND_ADD_FAILED=Failed to create Iscsi bond '${IscsiBondName}' in Data Center '${StoragePoolName}'. Line 743: ISCSI_BOND_EDIT_SUCCESS=Iscsi bond '${IscsiBondName}' was successfully updated. /s/Iscsi bond/iSCSI Bond Line 744: ISCSI_BOND_EDIT_FAILED=Failed to update Iscsi bond '${IscsiBondName}'. Line 745: ISCSI_BOND_REMOVE_SUCCESS=Iscsi bond '${IscsiBondName}' was removed from Data Center '${StoragePoolName}' Line 740: Line 741: ISCSI_BOND_ADD_SUCCESS=Iscsi bond '${IscsiBondName}' was successfully created in Data Center '${StoragePoolName}'. Line 742: ISCSI_BOND_ADD_FAILED=Failed to create Iscsi bond '${IscsiBondName}' in Data Center '${StoragePoolName}'. Line 743: ISCSI_BOND_EDIT_SUCCESS=Iscsi bond '${IscsiBondName}' was successfully updated. Line 744: ISCSI_BOND_EDIT_FAILED=Failed to update Iscsi bond '${IscsiBondName}'. /s/Iscsi bond/iSCSI Bond Line 745: ISCSI_BOND_REMOVE_SUCCESS=Iscsi bond '${IscsiBondName}' was removed from Data Center '${StoragePoolName}' Line 741: ISCSI_BOND_ADD_SUCCESS=Iscsi bond '${IscsiBondName}' was successfully created in Data Center '${StoragePoolName}'. Line 742: ISCSI_BOND_ADD_FAILED=Failed to create Iscsi bond '${IscsiBondName}' in Data Center '${StoragePoolName}'. Line 743: ISCSI_BOND_EDIT_SUCCESS=Iscsi bond '${IscsiBondName}' was successfully updated. Line 744: ISCSI_BOND_EDIT_FAILED=Failed to update Iscsi bond '${IscsiBondName}'. Line 745: ISCSI_BOND_REMOVE_SUCCESS=Iscsi bond '${IscsiBondName}' was removed from Data Center '${StoragePoolName}' /s/Iscsi bond/iSCSI Bond Line 742: ISCSI_BOND_ADD_FAILED=Failed to create Iscsi bond '${IscsiBondName}' in Data Center '${StoragePoolName}'. Line 743: ISCSI_BOND_EDIT_SUCCESS=Iscsi bond '${IscsiBondName}' was successfully updated. Line 744: ISCSI_BOND_EDIT_FAILED=Failed to update Iscsi bond '${IscsiBondName}'. Line 745: ISCSI_BOND_REMOVE_SUCCESS=Iscsi bond '${IscsiBondName}' was removed from Data Center '${StoragePoolName}' Line 746: ISCSI_BOND_REMOVE_FAILED=Failed to remove Iscsi bond '${IscsiBondName}' from Data Center '${StoragePoolName}' /s/Iscsi bond/iSCSI Bond http://gerrit.ovirt.org/#/c/22952/7/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties File frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties: Line 955: POWER_MANAGEMENT_ACTION_ON_ENTITY_ALREADY_IN_PROGRESS=Cannot perform ${action}. Another power management action is already in progress. Line 956: LABELED_NETWORK_INTERFACE_NOT_FOUND=A labeled network interface could not be found. Line 957: NETWORK_LABEL_CONFLICT=The networks represented by label cannot be configured on the same network interface. Line 958: Line 959: ISCSI_BOND_NOT_EXISTS=The specified iscsi bond doesn't exist. Please add here Cannot ${action} ${type}. http://gerrit.ovirt.org/#/c/22952/7/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties File frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties: Line 1079: POWER_MANAGEMENT_ACTION_ON_ENTITY_ALREADY_IN_PROGRESS=Another power management action, ${action}, is already in progress. Line 1080: LABELED_NETWORK_INTERFACE_NOT_FOUND=A labeled network interface could not be found. Line 1081: NETWORK_LABEL_CONFLICT=The networks represented by label cannot be configured on the same network interface. Line 1082: Line 1083: ISCSI_BOND_NOT_EXISTS=The specified iscsi bond doesn't exist. Please add here Cannot ${action} ${type}. -- To view, visit http://gerrit.ovirt.org/22952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06890ea40d22b86d9421cb1b0c68ea28bc430b0a Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
