Oved Ourfali has posted comments on this change. Change subject: webadmin, backend: control of hosted engine maintenance mode ......................................................................
Patch Set 1: (2 comments) didn't review the UI yet. several comments on the engine part http://gerrit.ovirt.org/#/c/23266/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java: Line 64: if (getVds().getStatisticsData().getHighlyAvailableIsConfigured()) { Line 65: SetHaMaintenanceModeVDSCommandParameters params Line 66: = new SetHaMaintenanceModeVDSCommandParameters(getVds(), HaMaintenanceMode.LOCAL, true); Line 67: if (!runVdsCommand(VDSCommandType.SetHaMaintenanceMode, params).getSucceeded()) { Line 68: setSucceeded(false); do we really want to prevent the rest of the maintenance process in case it fails moving the HA to maintenance? (not saying the answer is no... just making sure it was discussed/agreed). Line 69: return; Line 70: } Line 71: } Line 72: orderListOfRunningVmsOnVds(getVdsId()); Line 85: // if there's VM(s) in this VDS which is migrating, mark this command as async Line 86: // as the migration(s) is a step of this job, so this job must not be cleaned yet Line 87: if (isVmsExist()) { Line 88: ExecutionHandler.setAsyncJob(getExecutionContext(), true); Line 89: } Also, in addition to the comment above, there is the opposite case, in which the move to maintenance failed, but the HA was moved to maintenance... what should we do about that? Line 90: } Line 91: Line 92: protected boolean isVmsExist() { Line 93: return vms != null && !vms.isEmpty(); -- To view, visit http://gerrit.ovirt.org/23266 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f76f7ad63bcf6d7871c362b46cfa6e928eb9c74 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
