Federico Simoncelli has posted comments on this change. Change subject: core+webadmin: importing glance image as a template ......................................................................
Patch Set 5: Code-Review+1 (1 comment) Minor nit. http://gerrit.ovirt.org/#/c/23223/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCopyTaskHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCopyTaskHandler.java: Line 108: VmTemplate blankTemplate = DbFacade.getInstance().getVmTemplateDao().get(VmTemplateHandler.BLANK_VM_TEMPLATE_ID); Line 109: VmStatic masterVm = new VmStatic(blankTemplate); Line 110: Line 111: // Following the same convention as the glance disk name, using a GlanceTemplate prefix, followed by a short identifier Line 112: String vmTemplateName = "GlanceTemplate-" + Guid.newGuid().toString().substring(0, 7); Taking the same uuid of the glance image (as the glance disk) would have been better (same uuid for the disk/template coming from a certain glance image). Line 113: AddVmTemplateParameters parameters = new AddVmTemplateParameters(masterVm, vmTemplateName, "Glance imported template"); Line 114: VDSGroup vdsGroup = getVdsGroup(); Line 115: Line 116: if (vdsGroup != null) { -- To view, visit http://gerrit.ovirt.org/23223 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I537094bf9f738335833330665d29a1d39c65678d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
