Piotr Kliczewski has posted comments on this change. Change subject: engine: Json-rpc integration ......................................................................
Patch Set 20: (4 comments) http://gerrit.ovirt.org/#/c/20926/20/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java: Line 25 Line 26 Line 27 Line 28 Line 29 > not related to this patch Agree. Will remove. http://gerrit.ovirt.org/#/c/20926/20/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcUtils.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcUtils.java: Line 15: Line 16: public class JsonRpcUtils { Line 17: private static Log log = LogFactory.getLog(JsonRpcUtils.class); Line 18: Line 19: public static final int JSONRPC_PORT = 4044; > Shouldn't the port be a configuration property? It is hardcoded on the UI in the same way as xml port is. Using this value we have possibility to slowly migrate towards jsonrpc and abandon UI changes as we go. Line 20: Line 21: public static JsonRpcClient createClient(String hostName, int port, int connectionTimeOut, Line 22: int clientTimeOut, int connectionRetry, boolean isSecure) { Line 23: ManagerProvider provider = null; http://gerrit.ovirt.org/#/c/20926/20/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java: Line 253: } Line 254: Line 255: @Override Line 256: public OneVmReturnForXmlRpc changeDisk(String vmId, String imageLocation) { Line 257: // DriveSpec should be used instead of imageLocation > So TODO: ? Done Line 258: JsonRpcRequest request = Line 259: new RequestBuilder("VM.changeCD").withParameter("vmID", vmId) Line 260: .withParameter("driveSpec", imageLocation) Line 261: .build(); Line 265: } Line 266: Line 267: @Override Line 268: public OneVmReturnForXmlRpc changeFloppy(String vmId, String imageLocation) { Line 269: // DriveSpec should be used instead of imageLocation > So TODO: ? Done Line 270: JsonRpcRequest request = new RequestBuilder("VM.changeFloppy").withParameter("vmID", vmId) Line 271: .withParameter("driveSpec", imageLocation).build(); Line 272: Map<String, Object> response = Line 273: new FutureMap(this.client, request).withResponseKey("status"); -- To view, visit http://gerrit.ovirt.org/20926 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66ef0c98f07de6c447a5fffc42c9dbc94580df46 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
