Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: do not write into /usr/share/ovirt-engine-reports ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/23316/1/packaging/legacy-setup/ovirt-engine-reports-setup.py File packaging/legacy-setup/ovirt-engine-reports-setup.py: Line 279: file_handler.editParam("webAppNameCE", JRS_APP_NAME) Line 280: file_handler.editParam("appServerDir", DIR_DEPLOY) Line 281: file_handler.close() Line 282: Line 283: def setReportsDatasource(dir, db_dict): please use something different than dir, it's a python built-in function. Line 284: f = os.path.join(dir, 'resources/reports_resources/JDBC/data_sources/ovirt.xml') Line 285: logging.debug("editing reports datasource file %s", f) Line 286: xml_editor = utils.XMLConfigFileHandler(f) Line 287: xml_editor.open() Line 478: print "Warning: Weak Password." Line 479: Line 480: return userInput Line 481: Line 482: def editOvirtEngineAdminXml(dir, password): same here Line 483: """ Line 484: edit ovirt-engine-admin xml file and set password Line 485: TODO handle superuser password. Line 486: """ -- To view, visit http://gerrit.ovirt.org/23316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fed79744cf8767c9f6a6b017e2d9e5bc8402182 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
