Ayal Baron has posted comments on this change. Change subject: core: Remove storage type parameter in create storage pool VDS command ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/23293/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java: Line 81: if (isExistingStorage) { Line 82: return true; Line 83: } Line 84: Line 85: if (isLocalStorage(item) != dataCenter.isLocal()) { is it guaranteed that dataCenter is not null here? Line 86: return false; Line 87: } Line 88: Line 89: boolean isNoneDataCenter = dataCenter.getId().equals(StorageModel.UnassignedDataCenterId); -- To view, visit http://gerrit.ovirt.org/23293 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7efe3008fcdcbde4336ad026249b290b6b3eed5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
