Juan Hernandez has posted comments on this change.

Change subject: restapi: Allow enabling/disabling SSO
......................................................................


Patch Set 11:

(6 comments)

http://gerrit.ovirt.org/#/c/21911/11/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
File 
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml:

Line 75:           vm.description: xs:string
Line 76:           vm.comment: xs:string
Line 77:           vm.stateless: xs:boolean
Line 78:           vm.delete_protected: xs:boolean
Line 79:           vm.sso.methods.method--COLLECTION: {method: 'xs:string'}
You have to add the id here:

  vm.sso.methods.method--COLLECTION: {method.id: 'xs:string'}
Line 80:           vm.console.enabled: xs:boolean
Line 81:           vm.cpu.topology.sockets: xs:int
Line 82:           vm.placement_policy.affinity: xs:string
Line 83:           vm.placement_policy.host.id|name: xs:string


Line 145:           vm.comment: xs:string
Line 146:           vm.stateless: xs:boolean
Line 147:           vm.permissions.clone: xs:boolean
Line 148:           vm.delete_protected: xs:boolean
Line 149:           vm.sso.methods.method--COLLECTION: {method: 'xs:string'}
Same here.
Line 150:           vm.console.enabled: xs:boolean
Line 151:           vm.cpu.mode: xs:string
Line 152:           vm.cpu.topology.sockets: xs:int
Line 153:           vm.cpu_shares: xs:int


Line 194:           vm.description: xs:string
Line 195:           vm.comment: xs:string
Line 196:           vm.stateless: xs:boolean
Line 197:           vm.delete_protected: xs:boolean
Line 198:           vm.sso.methods.method--COLLECTION: {method: 'xs:string'}
Same here.
Line 199:           vm.console.enabled: xs:boolean
Line 200:           vm.cpu.topology.sockets: xs:int
Line 201:           vm.placement_policy.affinity: xs:string
Line 202:           vm.placement_policy.host.id|name: xs:string


Line 236:                 vm.comment: xs:string
Line 237:                 vm.stateless: xs:boolean
Line 238:                 vm.permissions.clone: xs:boolean
Line 239:                 vm.delete_protected: xs:boolean
Line 240:                 vm.sso.methods.method--COLLECTION: {method: 
'xs:string'}
Same here.
Line 241:                 vm.cpu.mode: xs:string
Line 242:                 vm.cpu.topology.sockets: xs:int
Line 243:                 vm.placement_policy.affinity: xs:string
Line 244:                 vm.placement_policy.host.id|name: xs:string


Line 3155:           template.domain.name: xs:string
Line 3156:           template.type: xs:string
Line 3157:           template.stateless: 'xs:boolean'
Line 3158:           template.delete_protected: xs:boolean
Line 3159:           template.sso.methods.method--COLLECTION: {method: 
'xs:string'}
Same here.
Line 3160:           template.console.enabled: xs:boolean
Line 3161:           template.placement_policy.affinity: xs:string
Line 3162:           template.description: xs:string
Line 3163:           template.comment: xs:string


Line 3202:           template.domain.name: xs:string
Line 3203:           template.type: xs:string
Line 3204:           template.stateless: 'xs:boolean'
Line 3205:           template.delete_protected: xs:boolean
Line 3206:           template.sso.methods.method--COLLECTION: {method: 
'xs:string'}
Same here.
Line 3207:           template.console.enabled: xs:boolean
Line 3208:           template.placement_policy.affinity: xs:string
Line 3209:           template.description: xs:string
Line 3210:           template.comment: xs:string


-- 
To view, visit http://gerrit.ovirt.org/21911
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25bf94646ea89684152e48f25ad604db6e59e86c
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to