Lior Vernia has posted comments on this change. Change subject: core: Mark management network as display and migration ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/22382/4/packaging/dbscripts/upgrade/03_04_0240_set_display_migration_cluster_network.sql File packaging/dbscripts/upgrade/03_04_0240_set_display_migration_cluster_network.sql: Line 8: FROM vdc_options Line 9: WHERE option_name='ManagementNetwork' Line 10: INTO mgmt_name; Line 11: Line 12: CREATE TEMP TABLE mgmt_table ( > Please avoid using temp tables Not sure I understand. What I'm iterating on here isn't the temporary table, it's the distinct cluster IDs in network_cluster. And then I use the temporary table to translate from cluster ID to corresponding management network ID. To use a cursor in this way instead of the temporary table, I think it would have to be parameterized, and re-opened and re-closed in each iteration of the loop, which I'm not sure is better than using this temporary table. Also, couldn't find the file you had referenced in the master branch anymore (maybe it was deprecated with the move to 3.4). Line 13: cluster_id UUID, Line 14: network_id UUID Line 15: ); Line 16: -- To view, visit http://gerrit.ovirt.org/22382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73bf3c583ae28bf32d7c602ec9f4b0fb5c7f391d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
