Ramesh N has posted comments on this change. Change subject: gluster: update volume capacity info in sync job ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/23011/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java: Line 854: } Line 855: }); Line 856: } Line 857: Line 858: private Map<Guid, GlusterStatus> getBrickStatusMap(GlusterVolumeAdvancedDetails volumeDetails) { > Is this used any more? If not, please remove. Done Line 859: Map<Guid, GlusterStatus> brickStatusMap = new HashMap<Guid, GlusterStatus>(); Line 860: for (BrickDetails brickDetails : volumeDetails.getBrickDetails()) { Line 861: brickStatusMap.put(brickDetails.getBrickProperties().getBrickId(), brickDetails.getBrickProperties() Line 862: .getStatus()); Line 866: Line 867: private Map<Guid, BrickProperties> getBrickPropertiesMap(GlusterVolumeAdvancedDetails volumeDetails) { Line 868: Map<Guid, BrickProperties> brickStatusMap = new HashMap<Guid, BrickProperties>(); Line 869: for (BrickDetails brickDetails : volumeDetails.getBrickDetails()) { Line 870: brickStatusMap.put(brickDetails.getBrickProperties().getBrickId(), brickDetails.getBrickProperties()); > brickDetails.getBrickProperties().getBrickId() could be null if the brick i We can add a null check, so that we will not update the capacity info and brick status until brick is added to engine DB. Line 871: } Line 872: return brickStatusMap; Line 873: } Line 874: -- To view, visit http://gerrit.ovirt.org/23011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd187eb59ab83c426db7e9ba48a04ae7e0bef0b9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
