Ramesh N has posted comments on this change. Change subject: engine: BLL command to refresh volume details ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/23262/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterVolumeDetailsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterVolumeDetailsCommand.java: Line 10: /** Line 11: * BLL command to refresh gluster volume details Line 12: */ Line 13: @NonTransactiveCommandAttribute Line 14: @LockIdNameAttribute(isWait = true) > Do you need a wait lock here? I think it's not required as locking is done Lock is done at refreshClusterHeavyWeightData(VDSGroup) method in GlusterSyncJob. But we can't use this method as it refresh all the volumes in Cluster. Line 15: public class RefreshGlusterVolumeDetailsCommand<T extends GlusterVolumeParameters> extends GlusterVolumeCommandBase<T> { Line 16: Line 17: public RefreshGlusterVolumeDetailsCommand(T params) { Line 18: super(params); Line 27: @Override Line 28: protected boolean canDoAction() { Line 29: if(!super.canDoAction()) { Line 30: return false; Line 31: } > Volume should be UP for fetching advanced details Done Line 32: Line 33: return true; Line 34: } Line 35: -- To view, visit http://gerrit.ovirt.org/23262 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie06c6a45e00f35df45e130cdceb592e81b67998e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
