Shubhendu Tripathi has posted comments on this change. Change subject: gluster: dao changes for volume capacity info ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/23010/7/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoDbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoDbFacadeImpl.java: Line 240: public BrickProperties mapRow(ResultSet rs, int rowNum) Line 241: throws SQLException { Line 242: BrickProperties brickProperties = new BrickProperties(); Line 243: brickProperties.setTotalSize(rs.getLong("total_space")); Line 244: // brickProperties.setUsedSize(rs.getLong("used_space")); TODO: Can we add usedSize as a brick properties > Shubhendu: Currently there is no field in BrickProperties to store the use I feel that should be fine to be done in UI. Line 245: brickProperties.setFreeSize(rs.getLong("free_space")); Line 246: return brickProperties; Line 247: } Line 248: } -- To view, visit http://gerrit.ovirt.org/23010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d67b7ee22f4cb6839d0f14d3f27f3e22149ff22 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
