Moti Asayag has posted comments on this change. Change subject: engine: Provide defaultRoute property for management network ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/23232/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java: Line 73: Line 74: if (FeatureSupported.defaultRoute(version) Line 75: && NetworkUtils.isManagementNetwork(network) Line 76: && (iface.getBootProtocol() == NetworkBootProtocol.DHCP Line 77: || iface.getBootProtocol() == NetworkBootProtocol.STATIC_IP > You should group these by parens to avoid confusion due to operator precede Done Line 78: && StringUtils.isNotEmpty(iface.getGateway()))) { Line 79: opts.put(DEFAULT_ROUTE, Boolean.TRUE); Line 80: } Line 81: http://gerrit.ovirt.org/#/c/23232/2/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 199 Line 200 Line 201 Line 202 Line 203 > Did you delete these on purpose? the dark side of the copy & paste (just without the copying) -- To view, visit http://gerrit.ovirt.org/23232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7bc20065ce28926ceb977c09f0480b345c66da5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
