Tal Nisan has posted comments on this change. Change subject: core,webadmin: Move storage type checks to domain instead of pool ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/23294/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java: Line 168: Line 169: setSucceeded(true); Line 170: } Line 171: Line 172: private StorageDomain getStorageDomainForVmMemory() { > What last comment? I don't understand what you're referring to. This one: "It is actually, I moved from transferring the domain id as the parameter to the storage domain object, this way I don't have to do a redundant fetch from the DB to get the object again" But it doesn't matter now since I will move it back to be Guid as Ayal asked Line 173: if (cachedStorageDomain == null && getVm() != null) { Line 174: long sizeNeeded = getVm().getTotalMemorySizeInBytes() / BYTES_IN_GB; Line 175: StorageDomain storageDomain = VmHandler.findStorageDomainForMemory(getVm().getStoragePoolId(), sizeNeeded); Line 176: if (storageDomain != null) { -- To view, visit http://gerrit.ovirt.org/23294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3db80f1749d93444e9cdac8038859b7d0865f6e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
