Allon Mureinik has posted comments on this change. Change subject: core: Change connect/disconnect storage commands to type agnostic ......................................................................
Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/23296/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePooServerCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePooServerCommandBase.java: Line 37: if (!connectionsTypeMap.containsKey(conn.getstorage_type())) { Line 38: connectionsTypeMap.put(connType, new ArrayList<StorageServerConnections>()); Line 39: } Line 40: connectionsTypeMap.get(connType).add(conn); Line 41: } Please use MultiValueMapUtils Line 42: } http://gerrit.ovirt.org/#/c/23296/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java: Line 55: return connectSucceeded; Line 56: } Line 57: Line 58: private boolean connectStorageServersByType(StorageType storageType, List<StorageServerConnections> connections) { Line 59: Map<String, String> retValues = (HashMap<String, String>) Backend s/HashMap/Map/ Line 60: .getInstance() Line 61: .getResourceManager() Line 62: .RunVdsCommand( Line 63: VDSCommandType.ConnectStorageServer, Line 58: private boolean connectStorageServersByType(StorageType storageType, List<StorageServerConnections> connections) { Line 59: Map<String, String> retValues = (HashMap<String, String>) Backend Line 60: .getInstance() Line 61: .getResourceManager() Line 62: .RunVdsCommand( use runVdsCommand Line 63: VDSCommandType.ConnectStorageServer, Line 64: new StorageServerConnectionManagementVDSParameters(getVds().getId(), Line 65: getStoragePool().getId(), storageType, connections)).getReturnValue(); Line 66: return StorageHelperDirector.getInstance().getItem(storageType).isConnectSucceeded(retValues, connections); -- To view, visit http://gerrit.ovirt.org/23296 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07a7fb8af9ce89a38b51cdb07a43a15f9c13f839 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
