Arik Hadas has posted comments on this change. Change subject: frontend: support for making sub-templates ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/23327/2/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.ui.xml File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.ui.xml: Line 40: <ge:StringEntityModelTextBoxEditor ui:field="commentEditor" /> Line 41: <e:ListModelTypeAheadListBoxEditor ui:field="clusterEditor" /> Line 42: <e:ListModelListBoxEditor ui:field="quotaEditor" /> Line 43: <ge:EntityModelCheckBoxEditor ui:field="isSubTemplateEditor"/> Line 44: <g:FlowPanel ui:field="subTemplateExpanderContent" visible="false" addStyleNames="{style.generalExpanderContent}"> > consider controlling visibility in behind code. Done Line 45: <e:ListModelTypeAheadListBoxEditor ui:field="baseTemplateEditor" /> Line 46: <ge:StringEntityModelTextBoxEditor ui:field="templateVersionNameEditor" /> Line 47: </g:FlowPanel> Line 48: <g:Label ui:field="disksAllocationLabel" addStyleNames="{style.disksAllocationLabel}" /> http://gerrit.ovirt.org/#/c/23327/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java: Line 109: getModel().getHash()), Line 110: vm.getStoragePoolId()); Line 111: } Line 112: Line 113: private void updateTemplate() > looks like it used in other place as well.. can you move to VmModelBehavior you're right - there is duplicate code spread over those behavior classes, but it is complicated to fix it because for pool a bit different code is used to update the templates. no doubt that we should organize this code, but let's not couple it with the template versions, it will take to much time to verify such changes.. Line 114: { Line 115: final DataCenterWithCluster dataCenterWithCluster = Line 116: (DataCenterWithCluster) getModel().getDataCenterWithClustersList().getSelectedItem(); Line 117: StoragePool dataCenter = dataCenterWithCluster == null ? null : dataCenterWithCluster.getDataCenter(); -- To view, visit http://gerrit.ovirt.org/23327 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic35174ac6736b96e8854885a711830c93a4b79ad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
