Gilad Chaplik has posted comments on this change. Change subject: webadmin: added the ksm checkbox ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/23360/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java: Line 704: cluster.setmax_vds_memory_over_commit(model.getMemoryOverCommit()); Line 705: cluster.setCountThreadsAsCores(Boolean.TRUE.equals(model.getVersionSupportsCpuThreads().getEntity()) Line 706: && Boolean.TRUE.equals(model.getCountThreadsAsCores().getEntity())); Line 707: cluster.setEnableKsm(Boolean.TRUE.equals(model.getEnableKsm().getEntity()) Line 708: || version.compareTo(Version.v3_4) < 0); no need to set value implicitly, use ClusterModel#version_SelectedItemChanged to control value and availability Line 709: cluster.setEnableBallooning(Boolean.TRUE.equals(model.getEnableBallooning().getEntity()) Line 710: && version.compareTo(Version.v3_3) >= 0); Line 711: cluster.setTransparentHugepages(version.compareTo(new Version("3.0")) >= 0); //$NON-NLS-1$ Line 712: cluster.setcompatibility_version(version); -- To view, visit http://gerrit.ovirt.org/23360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95414d676da17f00f8c23150b0cdef666a91ce74 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
