Sergey Gotliv has posted comments on this change. Change subject: engine, dao: Introduce ISCSI Bond entity, tables and dao ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/22951/11/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IscsiBond.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IscsiBond.java: Line 131: ObjectUtils.objectsEqual(name, iscsiBond.getName()) && Line 132: ObjectUtils.objectsEqual(description, iscsiBond.getDescription()) && Line 133: ObjectUtils.objectsEqual(storagePoolId, iscsiBond.getStoragePoolId()) && Line 134: ObjectUtils.objectsEqual(networkIds, iscsiBond.getNetworkIds()) && Line 135: ObjectUtils.objectsEqual(storageConnectionIds, iscsiBond.getStorageConnectionIds()); > I added a respond to Daniel on this issue in patch set 9. They are not transient, they are taken from the different table but they are persistent. Regarding, these methods, my personal opinion that persistent objects should be compared by id only, but across the project I see that different approach so I changed the code accordingly. For example, each host (VDS) contains the list of VdsInterface (Nics...) which is the part of equals and hashCode. Line 136: } -- To view, visit http://gerrit.ovirt.org/22951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12313c02810a2f0e75016bdd78b44da43f2154d4 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amador Pahim <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
