Mike Kolesnik has posted comments on this change. Change subject: engine: Log unsupported network update ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/23403/1//COMMIT_MSG Commit Message: Line 6: Line 7: engine: Log unsupported network update Line 8: Line 9: When hosts need to be updated on an unsupporting data center, an audit Line 10: log will be sent thast specifies that the automatic update will ne be > s/thast/that Done Line 11: happening. Line 12: Line 13: As specified in: Line 14: http://www.ovirt.org/Features/MultiHostNetworkConfiguration#Events http://gerrit.ovirt.org/#/c/23403/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java: Line 73: applyNetworkChangesToHosts(); Line 74: } else { Line 75: List<VdsNetworkInterface> nics = Line 76: getDbFacade().getInterfaceDao().getVdsInterfacesByNetworkId(getNetwork().getId()); Line 77: if (nics != null && !nics.isEmpty()) { > i don't think the the nics can be null, you can check only for emptiness Done Line 78: AuditLogDirector.log(this, AuditLogType.MULTI_UPDATE_NETWORK_NOT_POSSIBLE); Line 79: } Line 80: } Line 81: } -- To view, visit http://gerrit.ovirt.org/23403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b37fbdec5134b3131c1cafb1cd9e0596c2efb74 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
