Tomas Jelinek has posted comments on this change. Change subject: UI: hot set number of CPU when updating a VM ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/23252/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java: Line 273: if (isHotSetCpuSupported()) { Line 274: // cancel related events while fetching data Line 275: getModel().getTotalCPUCores().getEntityChangedEvent().removeListener(getModel()); Line 276: getModel().getCoresPerSocket().getSelectedItemChangedEvent().removeListener(getModel()); Line 277: getModel().getNumOfSockets().getSelectedItemChangedEvent().removeListener(getModel()); > I don't want any events on them if the dialog is dealing with hot plug situ ok Line 278: Line 279: AsyncDataProvider.getHostById(new AsyncQuery(this, new INewAsyncCallback() { Line 280: @Override Line 281: public void onSuccess(Object model, Object returnValue) { Line 370: Line 371: @Override Line 372: public void numOfSocketChanged() { Line 373: if (isHotSetCpuSupported()) { Line 374: int numOfSockets = extractIntFromListModel(getModel().getNumOfSockets()); > I can add it but it doesn't change much as the the last call to this method ok Line 375: int coresPerSocket = vm.getCpuPerSocket(); Line 376: getModel().getTotalCPUCores().setEntity(Integer.toString(numOfSockets * coresPerSocket)); Line 377: } else { Line 378: super.numOfSocketChanged(); Line 393: Line 394: getModel().getCoresPerSocket().setSelectedItem(vm.getCpuPerSocket()); Line 395: getModel().getNumOfSockets().setSelectedItem(vm.getNumOfSockets()); Line 396: Line 397: getModel().getNumOfSockets().getSelectedItemChangedEvent().addListener(getModel()); > its being called once AFAIK - after the callback is complete and runningHos ahh, right, since you have removed the listener this will not be called. ok than... Line 398: numOfSocketChanged(); Line 399: } else { Line 400: super.totalCpuCoresChanged(); Line 401: } -- To view, visit http://gerrit.ovirt.org/23252 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieac0e757c54b002eeab8f9099e6e8d151eb43340 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
