Liron Ar has posted comments on this change. Change subject: core: prevent maintenance when domain is still in use ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/22045/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java: Line 1082: } Line 1083: } Line 1084: Line 1085: // Step 3: try to synchronize the vds domain visibility when needed Line 1086: if (vdsNeedsRefresh) { shouldn't this be done only for hosts in status up? for other statuses we have the host recovery that'll try to connect the host to the pool again. Line 1087: log.warnFormat("VDS {0} was marked for a storage pool refresh", vds.getId()); Line 1088: vdsRefreshStoragePool(vds); Line 1089: } Line 1090: } Line 1088: vdsRefreshStoragePool(vds); Line 1089: } Line 1090: } Line 1091: Line 1092: private void vdsRefreshStoragePool(VDS vds) { Generally - this is a general problem not specific only to this case. I'm not sure if we want to handle it here and if that's the way and not through other solution (the event queue for example). Line 1093: // We need to make sure that whe storage pool is not in use for some other operation, Line 1094: // the most risky one is the deactivation of the master domain (migrateMaster) because Line 1095: // the master is migrated to another domain and we'll most likely request the refresh Line 1096: // with the wrong parameters. -- To view, visit http://gerrit.ovirt.org/22045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55cd5aa6a6dc32f374a4bb21b159d3cb30da65f5 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
