Martin Peřina has posted comments on this change. Change subject: core, tools: Supporting change password Url presentation ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/23250/7/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java: Line 349: if (!changePasswordUrl) { Line 350: return null; Line 351: } Line 352: Line 353: String changePasswordUrl = parser.getArg(Arguments.changePasswordUrl.name()); It would be more readable if local variable has a different name then the instance one. Line 354: if (StringUtils.isEmpty(changePasswordUrl)) { Line 355: throw new ManageDomainsResult(ManageDomainsResultEnum.INVALID_ARGUMENT_FOR_COMMAND, Line 356: "Password change URL must not be empty"); Line 357: } -- To view, visit http://gerrit.ovirt.org/23250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8eb0f858e26bdefffe526623d025fac47791711e Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
