Sergey Gotliv has posted comments on this change. Change subject: core: set local storage domain format ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23445/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddLocalStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddLocalStorageDomainCommand.java: Line 78: @Override Line 79: protected void executeCommand() { Line 80: getStorageDomain().setStorageFormat( Line 81: VersionStorageFormatUtil.getPreferredForVersion( Line 82: getStoragePool().getcompatibility_version(), getStoragePool().getStorageType())); Currently Tal is working to remove storageType checks from the storage pool level so getStoragePool().getStorageType() won't be available. More than that local storage is limited to local data center so why you can't use just StorageType.LOCALFS? Line 83: super.executeCommand(); Line 84: if (getSucceeded()) { Line 85: VdcReturnValueBase returnValue = Backend.getInstance() Line 86: .runInternalAction( -- To view, visit http://gerrit.ovirt.org/23445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec0ea5afe3e611dd72082791c497173b037d40a4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
