Gilad Chaplik has posted comments on this change.
Change subject: engine: Import VM more than once (#567580)
......................................................................
Patch Set 2: (5 inline comments)
replied to the comments..
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 130: if (retVal) {
if the client doesn't pass copy collapse, I want to tell him that he is wrong.
About the two ifs, who cares?
Line 219:
as you know I can't move this code to execute without messing with the flow, I
can separate the canDoAction into 3 methods (before, this part & after).
Line 220: if (retVal && getParameters().isImportAsNewEntity()) {
np
Line 223: setVmId(guid);
this test is performed later on as part of the original importVm
Line 555: }
I need!
because the new disk has a new VM with a new UUID
--
To view, visit http://gerrit.ovirt.org/4161
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa92d494c218b8dd79b3cb20867a806e29c15b6f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
