Allon Mureinik has posted comments on this change. Change subject: core,webadmin: Move storage type checks to domain instead of pool ......................................................................
Patch Set 6: Code-Review+2 (2 comments) http://gerrit.ovirt.org/#/c/23294/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java: Line 734: params.setEntityInfo(new EntityInfo(VdcObjectType.VM, getVm().getId())); Line 735: params.setParentParameters(getParameters()); Line 736: Line 737: StorageDomainStatic storageDomain = getStorageDomainStaticDAO().get(storageId); Line 738: if (storageDomain.getStorageType().isBlockDomain()) { isn't there a case that storageDomain could be null? Line 739: params.setUseCopyCollapse(true); Line 740: params.setVolumeType(VolumeType.Preallocated); Line 741: params.setVolumeFormat(VolumeFormat.RAW); Line 742: } http://gerrit.ovirt.org/#/c/23294/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java: Line 80: enclosingCommand.getTaskIdList().add(guid); Line 81: } Line 82: Line 83: private void createImageForMemoryDump() { Line 84: StorageDomainStatic storageDomainStatic = DbFacade.getInstance().getStorageDomainStaticDao().get(storageDomainId); s/DbFacade.getInstance()// Line 85: VDSReturnValue retVal = Line 86: Backend Line 87: .getInstance() Line 88: .getResourceManager() -- To view, visit http://gerrit.ovirt.org/23294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3db80f1749d93444e9cdac8038859b7d0865f6e5 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
