Allon Mureinik has posted comments on this change. Change subject: core,webadmin: Remove of storage pool type ......................................................................
Patch Set 7: Code-Review+1 (1 comment) ack on the backend. Please get the frontend and REST parts reviewed too. http://gerrit.ovirt.org/#/c/23402/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java: Line 172: } Line 173: return returnValue; Line 174: } Line 175: Line 176: protected boolean isStorageDomainCompatibleWithDC(StorageDomain storageDomain) { I'd return the ValidationResult here, but I guess it's equivalent to running validate() Line 177: StoragePoolValidator spv = new StoragePoolValidator(getStoragePool()); Line 178: if (storageDomain.getStorageType() == StorageType.GLUSTERFS) { Line 179: ValidationResult result = spv.isGlusterSupportedInDC(); Line 180: return validate(result); -- To view, visit http://gerrit.ovirt.org/23402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If29a4ecb9aa284b57e9f5218ca50cf4287452e3e Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
