Gilad Chaplik has posted comments on this change. Change subject: userportal: consider permissions of root templates ......................................................................
Patch Set 2: Code-Review+2 (2 comments) minor commments, other than that ACK http://gerrit.ovirt.org/#/c/23515/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalNewTemplateVmModelBehavior.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalNewTemplateVmModelBehavior.java: Line 42: ArrayList<VdcQueryParametersBase> parametersList = Line 43: new ArrayList<VdcQueryParametersBase>(Arrays.asList(new VdcQueryParametersBase[] { Line 44: getEntitiesWithPermittedActionParameters })); Line 45: Line 46: // Get clusters and templates remove comment Line 47: Frontend.getInstance().runMultipleQueries(queryTypeList, parametersList, this, getModel().getHash()); Line 48: } Line 49: Line 50: @Override Line 104: getModel().getBaseTemplate().setItems(filteredTemplates); Line 105: Line 106: getModel().getBaseTemplate().setSelectedItem(Linq.firstOrDefault(filteredTemplates, Line 107: new Linq.TemplatePredicate(currentTemplate.getBaseTemplateId()))); Line 108: } format. -- To view, visit http://gerrit.ovirt.org/23515 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf4d3967994b8a37b552b3b8ba63d09309a37093 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
