Juan Hernandez has posted comments on this change. Change subject: core: Adding support for returning password URL change to client ......................................................................
Patch Set 6: Code-Review+1 (2 comments) http://gerrit.ovirt.org/#/c/23319/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/authentication/AuthenticationResult.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/authentication/AuthenticationResult.java: Line 13: */ Line 14: public abstract boolean isSuccessful(); Line 15: Line 16: /** Line 17: * Resolves the detailed information into VdcBll messages We shouldn't have a reference to VdcBll messages in the authentication package, not even in the comments. Line 18: * @return Line 19: */ Line 20: public abstract List<String> resolveMessage(); Line 16: /** Line 17: * Resolves the detailed information into VdcBll messages Line 18: * @return Line 19: */ Line 20: public abstract List<String> resolveMessage(); I think this should be named getDetails(). -- To view, visit http://gerrit.ovirt.org/23319 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0825b1624696e687d76b867f4844f7016819cf2c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
