Juan Hernandez has posted comments on this change. Change subject: webadmin: Change LoginPopup to present clickable password URL change ......................................................................
Patch Set 7: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/23373/7/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractLoginPopupPresenterWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractLoginPopupPresenterWidget.java: Line 159: } Line 160: Line 161: private void formatAndSetErrorMessage(String message) { Line 162: Line 163: int urlIndex = message.indexOf(("http"));//$NON-NLS-1$ Why two parenthesis? Line 164: Line 165: if (message != null && urlIndex != -1) { //$NON-NLS-1$ Line 166: String beforeURL = message.substring(0, urlIndex); Line 167: String url = message.substring(urlIndex); -- To view, visit http://gerrit.ovirt.org/23373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I502cfcad23c3500f1e87e3f45657cf61e9c36d69 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
