Ravi Nori has posted comments on this change.

Change subject: core : No email notification sent when host recovers from 
previously reported condition
......................................................................


Patch Set 1:

@ Eli 

I had another look at the code and mechanism, there are several events for 
which the host can be moved to Non Operational. 

VDS_VERSION_NOT_SUPPORTED_FOR_CLUSTER
VDS_FAILURE

to list a couple.

VDS_FAILURE is mapped to VDS_ACTIVATE

and 

VDS_VERSION_NOT_SUPPORTED_FOR_CLUSTER is not in event_map table.

I think it is best to add a new event so the user can subscribe to VDS_DETECTED 
to cover all cases

-- 
To view, visit http://gerrit.ovirt.org/23399
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93038f1ef81aa82643eb1b0e4bf9bc523a28b22c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to