Allon Mureinik has posted comments on this change.
Change subject: core: Clear NPEs from unit-tests
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
Line 591: protected NetworkClusterDAO getNetworkClusterDAO() {
I'd externalize DbFacade.getInstance() to getDbFacade() or something like that
--
To view, visit http://gerrit.ovirt.org/4276
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I42b9391c350ebfb943052038d90d997373dd141d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
