Sandro Bonazzola has posted comments on this change. Change subject: packaging: build: rewrite ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23523/1/Makefile.am File Makefile.am: Line 15: # MA 02110-1301, USA. A copy of the GNU General Public License is Line 16: # also available at http://www.gnu.org/copyleft/gpl.html. Line 17: Line 18: AUTOMAKE_OPTIONS = foreign 1.9 Line 19: ACLOCAL_AMFLAGS = -I m4 m4 directory is not needed, please avoid to package empty hidden files. It's not a good packaging practice. Line 20: Line 21: OVIRT_CACHE_DIR ?= $(HOME)/ovirt-cache Line 22: Line 23: EXTRA_DIST = \ -- To view, visit http://gerrit.ovirt.org/23523 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b8dad0614300948cdc6fcc3ad2766ddff0caff1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
