Roy Golan has posted comments on this change. Change subject: core: automatically update vms on new version ......................................................................
Patch Set 15: (1 comment) http://gerrit.ovirt.org/#/c/23188/15/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java: Line 570: } Line 571: Line 572: private void endDefaultOperations() { Line 573: endUnlockOps(); Line 574: since 2 concurrent commands for create template can follow and regenerate the VMs we must avoid races were Vm could be regenrated twice and not in the order we tought. we need to make this a task which runs as a quartz job so it would run singular and we would be able to stop it and re-fire the job Line 575: // in case of new version of a template, update vms marked to use latest Line 576: if (getParameters().getBaseTemplateId() != null) { Line 577: for (Guid vmId : getVmDAO().getVmIdsForVersionUpdate(getParameters().getBaseTemplateId())) { Line 578: UpdateVmVersionParameters params = new UpdateVmVersionParameters(vmId); -- To view, visit http://gerrit.ovirt.org/23188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5449eee954bd6096b6f2e423a75a8cac3e5bcc3b Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
