Martin Peřina has posted comments on this change. Change subject: tools: Remove auxiliary email address from EventSender interface ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/23106/11/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java: Line 114: "UPDATE audit_log SET " + Line 115: "processed = 'true' " + Line 116: "WHERE " + Line 117: "processed = 'false' " + Line 118: "AND log_time < ?" > Isn't it better this way? Can't we have text only changes (also like fixing It maybe better, but it's not part of you patch, so please leave it as is. Line 119: ); Line 120: statement.setTimestamp(1, ts); Line 121: updatedRecords = statement.executeUpdate(); Line 122: } finally { -- To view, visit http://gerrit.ovirt.org/23106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic69ff7541fca8347fb7cb85665934ca704fa9d06 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
