Lior Vernia has uploaded a new change for review. Change subject: webadmin: Allow editing host network when part of label ......................................................................
webadmin: Allow editing host network when part of label Previously the edit button was invisible, now it is shown. Note that when a network is unmanaged, the "action button" in that case would remove the network from the interface, which would then "break" the label, therefore it is not displayed. Change-Id: I933eb0900f5a1663a5ae4f52eb05208e6db2c868 Bug-Url: https://bugzilla.redhat.com/1055952 Signed-off-by: Lior Vernia <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/54/23554/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java index 725ba85..de7efdf 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java @@ -127,7 +127,8 @@ protected void onMouseOver() { super.onMouseOver(); LogicalNetworkModel network = (LogicalNetworkModel) item; - if (network != null && network.getAttachedToNic() != null && !network.isAttachedViaLabel()) { + if (network != null && network.getAttachedToNic() != null + && (network.isManaged() || !network.isAttachedViaLabel())) { actionButton.setVisible(true); } } -- To view, visit http://gerrit.ovirt.org/23554 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I933eb0900f5a1663a5ae4f52eb05208e6db2c868 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Lior Vernia <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
