Yaniv Dary has posted comments on this change.

Change subject: packaging: setup: always deploy jasper war
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/23419/3/packaging/legacy-setup/ovirt-engine-reports-setup.py
File packaging/legacy-setup/ovirt-engine-reports-setup.py:

Line 1162:                     if adminPass is None:
Line 1163:                         adminPass = getAdminPass()
Line 1164:                     # Execute js-ant to create DB and deploy WAR
Line 1165:                     # May also set DB_EXIST to False if WAR is in 
need of an upgrade
Line 1166:                     deployJs(db_dict, TEMP_PGPASS)
> why? it is working this way perfectly, and it was not the case in the past.
This will mean that it will never replace the war or db. deployJS does both, so 
if we move from jrs 5.5 to 6.0, a upgrade will not happen like this.
Line 1167: 
Line 1168:                 logging.debug("Database status: %s" % DB_EXIST)
Line 1169:                 # Update oVirt-Engine vdc_options with reports 
relative url
Line 1170:                 updateServletDbRecord(TEMP_PGPASS)


-- 
To view, visit http://gerrit.ovirt.org/23419
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8799bde82f7c2da2b0a3074ea47e6ffc3eb898cd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to