Tal Nisan has posted comments on this change. Change subject: core: Add storage types to DiskImage entity ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/23410/8/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java: Line 192: for (String typeStr : splitTypes) { Line 193: try { Line 194: types.add(StorageType.forValue(Integer.parseInt(typeStr))); Line 195: } Line 196: catch (NumberFormatException e) { > When can we get NumberFormatException? We should validate the types before NumberFormatException can be thrown in case there is an error in the parsing from String to Integer, this is our way to flood up the exception in case something is wrong with the storage types column Line 197: throw new SQLException("Could not parse disk image storage domain type " + typeStr, e); Line 198: } Line 199: } Line 200: return types; -- To view, visit http://gerrit.ovirt.org/23410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8302972bb21fa076cd35fb308f5f660ca9200daa Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
