Allon Mureinik has posted comments on this change. Change subject: core,webadmin: Remove of storage pool type ......................................................................
Patch Set 1: Code-Review+1 (2 comments) Juan - can you look at the rest api part please? http://gerrit.ovirt.org/#/c/23590/1/backend/manager/modules/dal/src/test/resources/fixtures.xml File backend/manager/modules/dal/src/test/resources/fixtures.xml: Line 436: <column>id</column> Line 437: <column>name</column> Line 438: <column>description</column> Line 439: <column>is_local</column> Line 440: <column>status</column> please replace the tab with spaces Line 441: <column>master_domain_version</column> Line 442: <column>spm_vds_id</column> Line 443: <column>compatibility_version</column> Line 444: <column>_create_date</column> http://gerrit.ovirt.org/#/c/23590/1/packaging/dbscripts/create_dwh_views.sql File packaging/dbscripts/create_dwh_views.sql: Line 13 Line 14 Line 15 Line 16 Line 17 Is this removal intentional in DWH too? -- To view, visit http://gerrit.ovirt.org/23590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If29a4ecb9aa284b57e9f5218ca50cf4287452e3e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
