Allon Mureinik has posted comments on this change. Change subject: webadmin: Added storage type column to disks table ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23591/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java: Line 187: if (splitTypes == null) { Line 188: return null; Line 189: } Line 190: Line 191: ArrayList<StorageType> types = new ArrayList<>(); this isn't part of this patch (and IMHO, wrong altogether) Line 192: for (String typeStr : splitTypes) { Line 193: try { Line 194: types.add(StorageType.forValue(Integer.parseInt(typeStr))); Line 195: } -- To view, visit http://gerrit.ovirt.org/23591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c9566ee36967f587a2fee31c6db7aa40dcc2955 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
