Hello Michael Pasternak,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/23673

to review the following change.

Change subject: sdk: make sdk agnostic to base URI of api
......................................................................

sdk: make sdk agnostic to base URI of api

Change-Id: Iff1c103aba94d2006ae8be44c18c0bdede4cddbf
Signed-off-by: Michael pasternak <[email protected]>
---
M src/ovirtsdk/web/connection.py
1 file changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine-sdk refs/changes/73/23673/1

diff --git a/src/ovirtsdk/web/connection.py b/src/ovirtsdk/web/connection.py
index 0e2aad0..25b375e 100644
--- a/src/ovirtsdk/web/connection.py
+++ b/src/ovirtsdk/web/connection.py
@@ -164,9 +164,10 @@
         '''
         if cookies_jar and len(cookies_jar._cookies) > 0:
             for key in cookies_jar._cookies.keys():
-                if cookies_jar._cookies[key].has_key('/api') and \
-                    cookies_jar._cookies[key]['/api'].has_key('JSESSIONID'):
-                    return True
+                if key and len(cookies_jar._cookies[key]) > 0:
+                    for value in cookies_jar._cookies[key].values():
+                        if value and 'JSESSIONID' in value.keys():
+                            return True
         return False
 
     def getHeaders(self, headers={}, no_auth=False):
@@ -254,7 +255,7 @@
             else:
                 logging.error(
                       TypeError(
-                        "filter_header"+str(filter_header),
+                        "filter_header" + str(filter_header),
                         str(types.BooleanType) + ' is expected.'
                        )
                 )
@@ -267,7 +268,7 @@
             else:
                 logging.error(
                       TypeError(
-                        "session_timeout"+str(session_timeout),
+                        "session_timeout" + str(session_timeout),
                         str(types.IntType) + ' is expected.'
                       )
                 )


-- 
To view, visit http://gerrit.ovirt.org/23673
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff1c103aba94d2006ae8be44c18c0bdede4cddbf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_3.3
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to