Hello Michael Pasternak,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/23678
to review the following change.
Change subject: sdk: arguments name fixing
......................................................................
sdk: arguments name fixing
Change-Id: I3cb00b57eff2486f207db7d372cbadbbfb5467a2
Signed-off-by: Michael pasternak <[email protected]>
---
M
ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/ConnectionsPool.java
M
ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/IdleConnectionMonitorThread.java
2 files changed, 14 insertions(+), 14 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine-sdk-java
refs/changes/78/23678/1
diff --git
a/ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/ConnectionsPool.java
b/ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/ConnectionsPool.java
index 2bcf95b..dde9980 100644
---
a/ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/ConnectionsPool.java
+++
b/ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/ConnectionsPool.java
@@ -59,12 +59,12 @@
* oVirt API url
* @param sessionTimeout
* authentication session inactivity timeout
- * @param idleCheckTTL
+ * @param checkTtL
* idle connections check TTL
- * @param closeCloseTTl
+ * @param closeTtl
* idle connections close TTL
*/
- public ConnectionsPool(DefaultHttpClient client, URL url, Integer
sessionTimeout, long idleCheckTTL, long closeCloseTTl) {
+ public ConnectionsPool(DefaultHttpClient client, URL url, Integer
sessionTimeout, long checkTtL, long closeTtl) {
this.client = client;
this.cookieStore = this.client.getCookieStore();
this.url = url;
@@ -73,8 +73,8 @@
idleConnectionsWatchdog =
new IdleConnectionMonitorThread(
this.client.getConnectionManager(),
- idleCheckTTL,
- closeCloseTTl);
+ checkTtL,
+ closeTtl);
idleConnectionsWatchdog.start();
}
diff --git
a/ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/IdleConnectionMonitorThread.java
b/ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/IdleConnectionMonitorThread.java
index ea6e8bf..cc6a3c7 100644
---
a/ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/IdleConnectionMonitorThread.java
+++
b/ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/IdleConnectionMonitorThread.java
@@ -26,23 +26,23 @@
private final ClientConnectionManager connMgr;
private volatile boolean shutdown;
- long wait_ttl;
- long close_ttl;
+ long waitTtl;
+ long closeTtl;
/**
*
* @param connMgr
* ClientConnectionManager to watch at
- * @param wait_ttl
+ * @param waitTtl
* work cycle
- * @param close_ttl
+ * @param closeTtl
* close ttl
*/
- public IdleConnectionMonitorThread(ClientConnectionManager connMgr, long
wait_ttl, long close_ttl) {
+ public IdleConnectionMonitorThread(ClientConnectionManager connMgr, long
waitTtl, long closeTtl) {
super();
this.connMgr = connMgr;
- this.wait_ttl = wait_ttl;
- this.close_ttl = close_ttl;
+ this.waitTtl = waitTtl;
+ this.closeTtl = closeTtl;
}
@Override
@@ -50,9 +50,9 @@
try {
while (!shutdown) {
synchronized (this) {
- wait(this.wait_ttl);
+ wait(this.waitTtl);
connMgr.closeExpiredConnections();
- connMgr.closeIdleConnections(this.close_ttl,
TimeUnit.SECONDS);
+ connMgr.closeIdleConnections(this.closeTtl,
TimeUnit.SECONDS);
}
}
} catch (InterruptedException ex) {
--
To view, visit http://gerrit.ovirt.org/23678
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3cb00b57eff2486f207db7d372cbadbbfb5467a2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_3.3
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
