Liron Ar has posted comments on this change. Change subject: core: managed removal of memory volumes in negative flows ......................................................................
Patch Set 2: Arik - " That's exactly what I'm doing. The polling is done as part of the RemoveMemoryVolumesCommand as a separate flow that doesn't affect the rest of the ImportVmCommand/CreateAllSnapshotsFromVmCommand, just for the polling which was missing before." - Great, it wasn't clear from the commit message - "we need to remove the memory image in the end-action phase." at first read i understood it as you actually remove only when the tasks end. *"I think it will just make the RemoveImage command to be more complicated and I don't see why it is good. We plan to make the memory volumes much more similar to disk images and then it might be the right thing to do. currently I prefer to do it as it was done for hibernation volumes before." I don't really agree on that part, we should have the handling on one place, remove image command actually already have an option to not perform any db operations - RemoveImageParameters.getDbOperationScope() so only minor change might be required there instead of repeating it. *"To me it looks like a hack, I would like to use the infrastructure to do the polling whenever I can, as I do in this patch." Why is seems to you like a hack? that's the provided API, it's legitimate use..this is the reason for those methods to be exposed. -- To view, visit http://gerrit.ovirt.org/23222 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4b270ec0e1ab41cae34459dde9f9cf47b1b5bdf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
